Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): Use GET for insights when access token #20355

Closed
wants to merge 1 commit into from
Closed

fix(insights): Use GET for insights when access token #20355

wants to merge 1 commit into from

Conversation

webjunkie
Copy link
Contributor

Problem

We haven't thought of GET requests with an access token in #19859

Changes

  • put back the conditions where GET requests were made, but only if access token is given

How did you test this code?

@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.22 MB

compressed-size-action

@webjunkie webjunkie mentioned this pull request Feb 15, 2024
Closed
@webjunkie
Copy link
Contributor Author

Closed because we need a different approach, see #20372

@webjunkie webjunkie closed this Feb 15, 2024
@webjunkie webjunkie deleted the fix/insights-share-get branch February 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webjunkie